UX: show complete URL path if website domain is same as instance domain#5
Open
akshayutture-augment wants to merge 1 commit into
Open
UX: show complete URL path if website domain is same as instance domain#5akshayutture-augment wants to merge 1 commit into
akshayutture-augment wants to merge 1 commit into
Conversation
| end | ||
| end | ||
|
|
||
| def include_website_name |
There was a problem hiding this comment.
The include hook should be named include_website_name? (with a question mark) to be picked up by ActiveModel::Serializer; without it, this method won’t control attribute inclusion. Consider renaming to ensure website_name is only included when a website is present.
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.