scale-color $lightness must use $secondary for dark themes#4
scale-color $lightness must use $secondary for dark themes#4akshayutture-augment wants to merge 1 commit into
Conversation
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| font-weight: bold; | ||
| color: scale-color($primary, $lightness: 30%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 70%), scale-color($secondary, $lightness: 30%)); | ||
| } |
There was a problem hiding this comment.
Primary lightness changed from 30% to 70% here, which breaks the pattern used elsewhere (same lightness for light mode, $secondary for dark) and likely over-lightens this link in light theme.
🤖 Was this useful? React with 👍 or 👎
| @@ -99,7 +99,7 @@ | |||
|
|
|||
| .custom-message-length { | |||
| margin: -10px 0 10px 20px; | |||
There was a problem hiding this comment.
.custom-message-length uses 30% for $primary here, but desktop modal keeps this at 70% (with a 30% $secondary for dark), so this reversal looks unintended and may reduce readability in light theme.
🤖 Was this useful? React with 👍 or 👎
| display: inline-block; | ||
| margin-top: 5px; | ||
| color: scale-color($primary, $lightness: 30%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 50%), scale-color($secondary, $lightness: 50%)); |
There was a problem hiding this comment.
The “.name” color moved from 30% to 50% (and 50% for dark), which is inconsistent with common/base/user.scss where “.name” uses a 30%/$primary and 70%/$secondary split; this likely causes cross-view mismatch (also applies in app/assets/stylesheets/mobile/user.scss).
🤖 Was this useful? React with 👍 or 👎
| margin-bottom: 4px; | ||
| margin-top: 0; | ||
| color: scale-color($primary, $lightness: 20%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 50%), scale-color($secondary, $lightness: 50%)); |
There was a problem hiding this comment.
For h3, primary lightness changed from 20% to 50% (and 50% for dark), whereas the desktop variant keeps 20%/$primary and 80%/$secondary; this inconsistency looks accidental and may affect visual hierarchy.
🤖 Was this useful? React with 👍 or 👎
2 participants
No description provided.