OAuth credential sync and app integration enhancements#4
OAuth credential sync and app integration enhancements#4akshayutture-augment wants to merge 1 commit into
Conversation
…11059) * Add credential sync .env variables * Add webhook to send app credentials * Upsert credentials when webhook called * Refresh oauth token from a specific endpoint * Pass appSlug * Add credential encryption * Move oauth helps into a folder * Create parse token response wrapper * Add OAuth helpers to apps * Clean up * Refactor `appDirName` to `appSlug` * Address feedback * Change to safe parse * Remove console.log --------- Co-authored-by: Syed Ali Shahbaz <52925846+alishaz-polymath@users.noreply.github.com> Co-authored-by: Omar López <zomars@me.com>
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| const minimumTokenResponseSchema = z.object({ | ||
| access_token: z.string(), | ||
| // Assume that any property with a number is the expiry | ||
| [z.string().toString()]: z.number(), |
There was a problem hiding this comment.
The Zod object uses computed keys like [z.string().toString()], which will create a literal key like "[object Object]" rather than validating arbitrary properties; consider using z.object({ access_token: z.string() }).catchall(z.unknown()) (or a dedicated schema extension) to handle extra fields (including numeric expiry).
🤖 Was this useful? React with 👍 or 👎
| } | ||
|
|
||
| if (!refreshTokenResponse.data.refresh_token) { | ||
| refreshTokenResponse.data.refresh_token = "refresh_token"; |
There was a problem hiding this comment.
Setting refresh_token to the literal string "refresh_token" when it’s missing will corrupt stored credentials; consider preserving the existing refresh token from storage or avoiding overwriting it when not returned.
🤖 Was this useful? React with 👍 or 👎
| appSlug, | ||
| }), | ||
| }); | ||
| return response; |
There was a problem hiding this comment.
This function returns heterogeneous types: a fetch Response in the sync path and the raw result of refreshFunction() otherwise. Downstream code (e.g., expecting res.data) can break when the sync path returns a Response without .data. Consider normalizing the return shape (e.g., always returning parsed JSON tokens).
🤖 Was this useful? React with 👍 or 👎
2 participants
No description provided.