Skip to content

Enhance embed URL handling and validation system#4

Open
everettbu wants to merge 1 commit into
embed-url-handling-prefrom
embed-url-handling-post
Open

Enhance embed URL handling and validation system#4
everettbu wants to merge 1 commit into
embed-url-handling-prefrom
embed-url-handling-post

Conversation

@everettbu

Copy link
Copy Markdown
Contributor

Test 4

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been open for 60 days with no activity. To keep it open, remove the stale tag, push code, or add a comment. Otherwise, it will be closed in 14 days.

@mfeuerstein mfeuerstein left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review — approved

Reviewed 28 files. 0 high-severity issues found. Verdict: approved.

app/models/post.rb (low)

  • Reviewed app/models/post.rb — looks good

app/jobs/regular/retrieve_topic.rb (low)

  • Reviewed app/jobs/regular/retrieve_topic.rb — looks good

Gemfile_rails4.lock (low)

  • Reviewed Gemfile_rails4.lock — looks good

app/assets/javascripts/embed.js (low)

  • Reviewed app/assets/javascripts/embed.js — looks good

app/controllers/embed_controller.rb (low)

  • Reviewed app/controllers/embed_controller.rb — looks good

app/jobs/scheduled/poll_feed.rb (low)

  • Reviewed app/jobs/scheduled/poll_feed.rb — looks good

app/views/layouts/embed.html.erb (low)

  • Reviewed app/views/layouts/embed.html.erb — looks good

app/views/embed/loading.html.erb (low)

  • Reviewed app/views/embed/loading.html.erb — looks good

app/views/embed/best.html.erb (low)

  • Reviewed app/views/embed/best.html.erb — looks good

app/models/topic_embed.rb (low)

  • Reviewed app/models/topic_embed.rb — looks good

config/routes.rb (low)

  • Reviewed config/routes.rb — looks good

Gemfile (low)

  • Reviewed Gemfile — looks good

config/locales/client.en.yml (low)

  • Reviewed config/locales/client.en.yml — looks good

app/assets/stylesheets/embed.css.scss (low)

  • Reviewed app/assets/stylesheets/embed.css.scss — looks good

db/migrate/20131217174004_create_topic_embeds.rb (low)

  • Reviewed db/migrate/20131217174004_create_topic_embeds.rb — looks good

config/locales/server.en.yml (low)

  • Reviewed config/locales/server.en.yml — looks good

config/site_settings.yml (low)

  • Reviewed config/site_settings.yml — looks good

lib/topic_retriever.rb (low)

  • Reviewed lib/topic_retriever.rb — looks good

spec/components/topic_retriever_spec.rb (low)

  • Reviewed spec/components/topic_retriever_spec.rb — looks good

lib/post_creator.rb (low)

  • Reviewed lib/post_creator.rb — looks good

lib/tasks/disqus.thor (low)

  • Reviewed lib/tasks/disqus.thor — looks good

db/migrate/20131210181901_migrate_word_counts.rb (low)

  • Reviewed db/migrate/20131210181901_migrate_word_counts.rb — looks good

spec/jobs/poll_feed_spec.rb (low)

  • Reviewed spec/jobs/poll_feed_spec.rb — looks good

db/migrate/20131219203905_add_cook_method_to_posts.rb (low)

  • Reviewed db/migrate/20131219203905_add_cook_method_to_posts.rb — looks good

spec/controllers/embed_controller_spec.rb (low)

  • Reviewed spec/controllers/embed_controller_spec.rb — looks good

db/migrate/20131223171005_create_top_topics.rb (low)

  • Reviewed db/migrate/20131223171005_create_top_topics.rb — looks good

lib/post_revisor.rb (low)

  • Reviewed lib/post_revisor.rb — looks good

spec/models/topic_embed_spec.rb (low)

  • Reviewed spec/models/topic_embed_spec.rb — looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants