Advanced date override handling and timezone compatibility improvements#7
Advanced date override handling and timezone compatibility improvements#7everettbu wants to merge 1 commit into
Conversation
* fix date override for fixed round robin + time zone in date override * check if slot is within working hours of fixed hosts * add test for date override in different time zone * fix date overrides for not fixed hosts (round robin) * code clean up * fix added test * use the correct timezone of user for date overrides --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on August 11, 2025
Learn more in the Cursor dashboard.
| if (workingHour.days.includes(slotStartTime.day())) { | ||
| const start = slotStartTime.hour() * 60 + slotStartTime.minute(); | ||
| const end = slotStartTime.hour() * 60 + slotStartTime.minute(); | ||
| if (start < workingHour.startTime || end > workingHour.endTime) { |
There was a problem hiding this comment.
Bug: Working Hours Validation Uses Incorrect End Time
In the checkIfIsAvailable function, the start and end variables used for working hours validation are calculated identically using slotStartTime. The end variable should instead be calculated using slotEndTime to correctly check if the entire slot duration falls within the defined working hours.
Locations (1)
| slotStartTime.format("YYYY MM DD") | ||
| ) { | ||
| dateOverrideExist = true; | ||
| if (dayjs(date.start).add(utcOffset, "minutes") === dayjs(date.end).add(utcOffset, "minutes")) { |
There was a problem hiding this comment.
Bug: Dayjs Comparison Error
Strict equality (===) is incorrectly used to compare Dayjs objects, which always returns false for different object instances. The .isSame() method should be used instead to properly compare the date/time values.
Locations (1)
|
This PR is being marked as stale due to inactivity. |
3 participants
Test 7