Allow inclusion of higher order modes#7
Open
SSingh087 wants to merge 2 commits intoahnitz:conmodelfrom
Open
Conversation
* separate evaluation of l, m * if `if_hom` True calculation wrt l = m = 2 mode
ahnitz
reviewed
Jul 4, 2022
pycbc/inference/models/relbin.py
Outdated
| # generate fiducial waveform | ||
| f_lo = self.kmin[ifo] * self.df[ifo] | ||
|
|
||
| if is_hom: |
Owner
There was a problem hiding this comment.
This seems a bit artificial here. Is there a reason this can't be set from the config file rather than hard coding the relation? There may be times we don't want to truncate at the same time for example.
Author
There was a problem hiding this comment.
Yes, indeed this can be set from the config file directly and was not required for this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if_homTrue calculation wrt l = m = 2 mode