fix(mcp-proxy): return launcher approval center process#102
Merged
Conversation
Return the launcher-spawned Approval Center Popen handle to the shared lifecycle waiter so early exits can be diagnosed consistently across setup and launch paths. Increase the managed startup wait budget to cover slower macOS full-matrix startup without changing approval policy or connector behavior. Implemented with assistance from Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The previous lifecycle hardening covered the setup/CLI managed-center path but the launcher path still returned no process handle from its spawn callback. That meant the shared waiter could not diagnose early child exits from launcher-managed Approval Center startup. The full release matrix also shows macOS startup needs a wider wait budget than 30s under full-suite load.
Validation
Release/tag/publish remain blocked until PR checks and the full pre-release matrix pass.