fix(core): use @JsonProperty on Event.isLast() to preserve JSON key#1052
Open
LearningGp wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix(core): use @JsonProperty on Event.isLast() to preserve JSON key#1052LearningGp wants to merge 1 commit intoagentscope-ai:mainfrom
LearningGp wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Jackson JSON serialization of Event.isLast so the emitted JSON key remains isLast (instead of being normalized to last via JavaBeans boolean getter conventions), keeping serialization consistent with existing constructor-based deserialization.
Changes:
- Annotate
Event.isLast()with@JsonProperty("isLast")to force the JSON property name during serialization. - Add a regression test verifying JSON output contains
"isLast"(and not"last") and that round-trip deserialization preserves the value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/agent/Event.java | Adds @JsonProperty("isLast") to the boolean getter to preserve the intended JSON key on serialization. |
| agentscope-core/src/test/java/io/agentscope/core/agent/EventTest.java | Adds a regression test covering the JSON key name and round-trip behavior for isLast. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.10
Description
fix(core): use @JsonProperty on Event.isLast() to preserve JSON key
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)