fix(auto-memory): preserve temporal grounding in notes#313
Conversation
|
Thanks for the PR. I checked the change against the current auto-memory flow and the temporal-reasoning issue discussed in #302. I agree with the general direction: for historical conversations, the memory-writing step should not silently reinterpret relative phrases such as "today", "yesterday", or "recently" against the system runtime date. Keeping the source conversation time available to the generated note is useful, and That said, I am a little concerned that the current prompt wording may be too benchmark-oriented for the default Could we consider one of these adjustments before merging?
So I think the core idea is valid, but I would prefer to avoid making the default memory format too test-set-specific. A lighter default prompt plus a stronger evaluation prompt would probably give us the best tradeoff. |
|
Thanks for the detailed review. I updated the PR to keep the default auto-memory behavior less benchmark-specific:
Verification:
|
Summary
Refs #302
Verification
7 passed in 0.91s
check yaml...............................................................Passed
check xml............................................(no files to check)Skipped
check toml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
detect private key.......................................................Passed
trim trailing whitespace.................................................Passed
Add trailing commas......................................................Passed
black....................................................................Passed
flake8...................................................................Passed
pylint...................................................................Passed
Check package with Pyroma................................................Passed