test: make multi-worker bob setup deterministic#985
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Contributor
📊 CI Metrics ReportSummary
By Role
Per-Test Breakdown
Trends✅ 1 test(s) improved (fewer LLM calls) Generated by HiClaw CI on 2026-07-03 09:09:38 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-06-multi-workercreate Bob viahiclaw apply workerinstead of a Manager DM requestWhy
Recent failures on #972, #983, #984, and older PRs all failed in
test-06-multi-workerwith the same pattern: the Manager did not produce a matching Bob creation reply,wait_worker_provisioned bobtimed out,hiclaw get workers bobreturned 404, andhiclaw-worker-bobdid not exist. The logs also show the Manager processing unrelated heartbeat/task work or denied shell commands during the Bob creation window.This makes Bob creation an unreliable LLM interaction inside a test whose stated purpose is multi-worker collaboration.
test-02-create-workeralready covers Manager-mediated worker creation for Alice;test-06can use deterministic setup for Bob.Verification
bash -n tests/test-06-multi-worker.shgit diff --checkI could not run the embedded integration test locally because this environment cannot access
/var/run/docker.sock(permission denied).