Skip to content

fix(manager): stop repeated diagnostic loops#975

Open
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-974-manager-diagnostic-loop
Open

fix(manager): stop repeated diagnostic loops#975
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-974-manager-diagnostic-loop

Conversation

@RerankerGuo

Copy link
Copy Markdown

Summary

  • add Manager prompt safeguards against repeating the same no-op or malformed troubleshooting command
  • define Worker deletion completion as the target disappearing from hiclaw get workers
  • update worker lifecycle guidance to avoid looping on Matrix room probes such as copaw channels list after deletion

Fixes #974.

Tests

  • git diff --check
  • rg -n "Diagnostic loop safeguard|Worker deletion is complete|Delete Completion Boundary|Stop repeated diagnostics" manager/agent/AGENTS.md manager/agent/copaw-manager-agent/AGENTS.md manager/agent/skills/worker-management/references/lifecycle.md manager/agent/skills/worker-management/SKILL.md

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📊 CI Metrics Report

Summary

Metric Current Baseline Change
LLM Calls 103 81 +22 ↑ +27.2%
Input Tokens 3009862 2803871 +205991 ↑ +7.3%
Output Tokens 25918 16791 +9127 ↑ +54.4%
Total Tokens 3035780 2820662 +215118 ↑ +7.6%

By Role

Role Metric Current Baseline Change
🧠 Manager LLM Calls 75 68 +7 ↑ +10.3%
Input Tokens 2348368 2502214 -153846 ↓ -6.1%
Output Tokens 14467 13725 +742 ↑ +5.4%
Total Tokens 2362835 2515939 -153104 ↓ -6.1%
🔧 Workers LLM Calls 28 13 +15 ↑ +115.4%
Input Tokens 661494 301657 +359837 ↑ +119.3%
Output Tokens 11451 3066 +8385 ↑ +273.5%
Total Tokens 672945 304723 +368222 ↑ +120.8%

Per-Test Breakdown

Test Mgr Calls Wkr Calls Δ Calls Mgr In Wkr In Mgr Out Wkr Out Δ Tokens Trend
02-create-worker 4 0 -8 ↓ -66.7% 108183 0 657 0 -249782 ↓ -69.7% ✅ improved
03-assign-task 11 5 +1 ↑ +6.7% 299705 114002 1732 726 -57491 ↓ -12.1% ⚠️ regressed
04-human-intervene 15 10 +12 ↑ +92.3% 394396 238810 2513 1231 +203952 ↑ +47.1% ⚠️ regressed
05-heartbeat 9 2 +4 ↑ +57.1% 283786 43729 1822 239 +54324 ↑ +19.7% ⚠️ regressed
06-multi-worker 36 11 +13 ↑ +38.2% 1262298 264953 7743 9255 +264115 ↑ +20.6% ⚠️ regressed

Trends

1 test(s) improved (fewer LLM calls)
⚠️ 4 test(s) regressed (more LLM calls)


Generated by HiClaw CI on 2026-07-02 10:54:22 UTC


📦 Download debug logs & test artifacts

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=hermes)

Commit: 25b153e
Workflow run: #1403

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

简单的使用就会陷入死循环,很慢 || Simple use will cause an infinite loop, which is very slow

1 participant