Skip to content

fix(config): pass custom model parameters to controller#973

Open
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-961-model-params-env
Open

fix(config): pass custom model parameters to controller#973
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-961-model-params-env

Conversation

@RerankerGuo

Copy link
Copy Markdown

Summary

  • pass custom model context/max-token/reasoning/vision env vars into the embedded controller container
  • expose the same model parameter overrides in Helm values and render them into the runtime Secret
  • teach controller config to read reasoning/vision overrides and forward all model parameters to agentconfig

Fixes #961.

Tests

  • bash -n install/hiclaw-install.sh
  • git diff --check

Not run: go test ./internal/config ./internal/agentconfig because this environment does not have Go (go: command not found).
Not run: helm template ... because Helm is not installed (helm: command not found).

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📊 CI Metrics Report

Summary

Metric Current Baseline Change
LLM Calls 132 81 +51 ↑ +63.0%
Input Tokens 4513112 2803871 +1709241 ↑ +61.0%
Output Tokens 24885 16791 +8094 ↑ +48.2%
Total Tokens 4537997 2820662 +1717335 ↑ +60.9%

By Role

Role Metric Current Baseline Change
🧠 Manager LLM Calls 102 68 +34 ↑ +50.0%
Input Tokens 3745559 2502214 +1243345 ↑ +49.7%
Output Tokens 19682 13725 +5957 ↑ +43.4%
Total Tokens 3765241 2515939 +1249302 ↑ +49.7%
🔧 Workers LLM Calls 30 13 +17 ↑ +130.8%
Input Tokens 767553 301657 +465896 ↑ +154.4%
Output Tokens 5203 3066 +2137 ↑ +69.7%
Total Tokens 772756 304723 +468033 ↑ +153.6%

Per-Test Breakdown

Test Mgr Calls Wkr Calls Δ Calls Mgr In Wkr In Mgr Out Wkr Out Δ Tokens Trend
02-create-worker 6 0 -6 ↓ -50.0% 157808 0 899 0 -199915 ↓ -55.7% ✅ improved
03-assign-task 11 5 +1 ↑ +6.7% 301478 113068 1760 836 -56514 ↓ -11.9% ⚠️ regressed
04-human-intervene 15 0 +2 ↑ +15.4% 362832 0 2158 0 -68008 ↓ -15.7% ⚠️ regressed
05-heartbeat 8 0 +1 ↑ +14.3% 248469 0 1436 0 -25347 ↓ -9.2% ⚠️ regressed
06-multi-worker 62 25 +53 ↑ +155.9% 2674972 654485 13429 4367 +2067119 ↑ +161.5% ⚠️ regressed

Trends

1 test(s) improved (fewer LLM calls)
⚠️ 4 test(s) regressed (more LLM calls)


Generated by HiClaw CI on 2026-07-02 09:23:15 UTC


📦 Download debug logs & test artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manager配置反复重置 || manager configuration is reset repeatedly

1 participant