fix(manager): avoid restart recovery local failure

[RerankerGuo]

Summary

• remove a top-level local declaration from the Manager restart recovery Worker recreation block
• prevent the Manager entrypoint from exiting under set -e when that recovery path is reached after restart
• add a regression test that checks startup script syntax and forbids top-level local declarations in the restart recovery block

Fixes #952.

Verification

• bash manager/tests/test-manager-startup-script.sh
• bash -n manager/scripts/init/start-manager-agent.sh manager/tests/test-manager-startup-script.sh
• git diff --check

[github-actions]

📊 CI Metrics Report

Summary

Metric	Current	Baseline	Change
LLM Calls	184	81	+103 ↑ +127.2%
Input Tokens	6477198	2803871	+3673327 ↑ +131.0%
Output Tokens	48666	16791	+31875 ↑ +189.8%
Total Tokens	6525864	2820662	+3705202 ↑ +131.4%

By Role

Role	Metric	Current	Baseline	Change
🧠 Manager	LLM Calls	118	68	+50 ↑ +73.5%
	Input Tokens	4589231	2502214	+2087017 ↑ +83.4%
	Output Tokens	24283	13725	+10558 ↑ +76.9%
	Total Tokens	4613514	2515939	+2097575 ↑ +83.4%
🔧 Workers	LLM Calls	66	13	+53 ↑ +407.7%
	Input Tokens	1887967	301657	+1586310 ↑ +525.9%
	Output Tokens	24383	3066	+21317 ↑ +695.3%
	Total Tokens	1912350	304723	+1607627 ↑ +527.6%

Per-Test Breakdown

Test	Mgr Calls	Wkr Calls	Δ Calls	Mgr In	Wkr In	Mgr Out	Wkr Out	Δ Tokens	Trend
02-create-worker	5	0	-7 ↓ -58.3%	126765	0	475	0	-231382 ↓ -64.5%	✅ improved
03-assign-task	13	5	+3 ↑ +20.0%	358193	113471	2167	941	+1116 ↑ +0.2%	⚠️ regressed
04-human-intervene	15	12	+14 ↑ +107.7%	396324	293553	2353	1374	+260606 ↑ +60.2%	⚠️ regressed
05-heartbeat	9	5	+7 ↑ +100.0%	285446	129994	2036	939	+143163 ↑ +52.0%	⚠️ regressed
06-multi-worker	76	44	+86 ↑ +252.9%	3422503	1350949	17252	21129	+3531699 ↑ +275.9%	⚠️ regressed

Trends

✅ 1 test(s) improved (fewer LLM calls)
⚠️ 4 test(s) regressed (more LLM calls)

---

Generated by HiClaw CI on 2026-07-02 08:59:25 UTC

---

📦 Download debug logs & test artifacts