Skip to content

fix(manager): add safe worker deletion wrapper#969

Open
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-967-delete-worker-loop
Open

fix(manager): add safe worker deletion wrapper#969
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-967-delete-worker-loop

Conversation

@RerankerGuo

Copy link
Copy Markdown

Summary

  • add a worker-management delete wrapper that calls hiclaw delete worker <name> with the valid positional CLI syntax
  • return structured JSON so the Manager only reports deletion after command success
  • add a records-only cleanup path for state.json, worker-lifecycle.json, and workers-registry.json to avoid malformed write_file cleanup loops
  • update Worker management guidance and lifecycle reference to use the wrapper

Fixes #967.

Verification

  • bash -n manager/agent/skills/worker-management/scripts/delete-worker.sh manager/tests/test-delete-worker-script.sh
  • git diff --check
  • bash manager/tests/test-delete-worker-script.sh (skips in this host because jq is not installed; Manager images install jq, and the test runs full assertions when jq exists)

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=hermes)

Commit: 602e96e
Workflow run: #1397

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📊 CI Metrics Report

Summary

Metric Current Baseline Change
LLM Calls 149 81 +68 ↑ +84.0%
Input Tokens 5359143 2803871 +2555272 ↑ +91.1%
Output Tokens 38050 16791 +21259 ↑ +126.6%
Total Tokens 5397193 2820662 +2576531 ↑ +91.3%

By Role

Role Metric Current Baseline Change
🧠 Manager LLM Calls 96 68 +28 ↑ +41.2%
Input Tokens 3684226 2502214 +1182012 ↑ +47.2%
Output Tokens 17346 13725 +3621 ↑ +26.4%
Total Tokens 3701572 2515939 +1185633 ↑ +47.1%
🔧 Workers LLM Calls 53 13 +40 ↑ +307.7%
Input Tokens 1674917 301657 +1373260 ↑ +455.2%
Output Tokens 20704 3066 +17638 ↑ +575.3%
Total Tokens 1695621 304723 +1390898 ↑ +456.4%

Per-Test Breakdown

Test Mgr Calls Wkr Calls Δ Calls Mgr In Wkr In Mgr Out Wkr Out Δ Tokens Trend
02-create-worker 11 0 -1 ↓ -8.3% 323820 0 1841 0 -32961 ↓ -9.2% ✅ improved
03-assign-task 11 7 +3 ↑ +20.0% 369084 157933 1738 1146 +56245 ↑ +11.9% ⚠️ regressed
04-human-intervene 21 11 +19 ↑ +146.2% 669937 265572 3176 1222 +506909 ↑ +117.1% ⚠️ regressed
05-heartbeat 9 2 +4 ↑ +57.1% 368413 48932 2212 393 +144698 ↑ +52.6% ⚠️ regressed
06-multi-worker 44 33 +43 ↑ +126.5% 1952972 1202480 8379 17943 +1901640 ↑ +148.6% ⚠️ regressed

Trends

1 test(s) improved (fewer LLM calls)
⚠️ 4 test(s) regressed (more LLM calls)


Generated by HiClaw CI on 2026-07-02 08:44:41 UTC


📦 Download debug logs & test artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

关于移除worker陷入死循环

1 participant