fix: create stub files on init and rename apiVersion to v1alpha1#32
Open
wiliyam wants to merge 1 commit intoagents-oss:mainfrom
Open
fix: create stub files on init and rename apiVersion to v1alpha1#32wiliyam wants to merge 1 commit intoagents-oss:mainfrom
wiliyam wants to merge 1 commit intoagents-oss:mainfrom
Conversation
skokaina
requested changes
Apr 7, 2026
Contributor
skokaina
left a comment
skokaina
left a comment
There was a problem hiding this comment.
Thank you for your contribution, overall this is a great push, there's a intended migration script that should keep target as v1
Contributor
There was a problem hiding this comment.
This is an assistant script to help migrate later from v1aplha1 to v1
| migrate(raw: Record<string, unknown>): Record<string, unknown> { | ||
| return { | ||
| ...raw, | ||
| apiVersion: 'agentspec.io/v1', |
| */ | ||
| export const v1alpha1ToV1: Migration = { | ||
| from: 'agentspec/v1alpha1', | ||
| to: 'agentspec.io/v1', |
| const migrations: Migration[] = [v1alpha1ToV1] | ||
| const migrations: Migration[] = [v1alpha1ToV1, v1ToV1Alpha1] | ||
|
|
||
| export const LATEST_API_VERSION = 'agentspec.io/v1' |
| mockIsLatestVersion.mockReturnValue(false) | ||
| mockMigrateManifest.mockReturnValue({ | ||
| result: migratedObj, | ||
| migrationsApplied: ['agentspec/v1alpha1 → agentspec.io/v1'], |
Contributor
There was a problem hiding this comment.
should remain v1 as a target, same for others
Collaborator
|
Hey @wiliyam, this PR has picked up merge conflicts against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20 and #21
Issue #20 — init stub files
agentspec initgenerated anagent.yamlreferencing$file:prompts/system.mdbut never created the file, breaking the quick-start flow at thegeneratestep.Changes:
agent.yaml, init now createsprompts/system.mdwith a sensible default system prompt--evalwas selected, also createseval/datasets/qa.jsonlstubIssue #21 — rename apiVersion
The manifest
apiVersion: agentspec.io/v1signalled a stable API but the schema is still evolving.Changes:
agentspec.io/v1alpha1across all source, test, example, and demo files (39 files)v1ToV1Alpha1so existing manifests usingagentspec.io/v1are silently upgraded rather than failing validation