fix(supervise): share auth keys between supervise and user create#53
Open
manavjaiswal wants to merge 1 commit intoagent0ai:mainfrom
Open
fix(supervise): share auth keys between supervise and user create#53manavjaiswal wants to merge 1 commit intoagent0ai:mainfrom
manavjaiswal wants to merge 1 commit intoagent0ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes
node space superviseuse the same default auth-key store asnode space user create, so password verifiers created by the CLI can be opened by the running supervised server.What changed:
node space supervisehelp/docs now describe the shared auth-store behaviorHow to test:
CUSTOMWARE_PATHto a real absolute path.node space user create <username> --password <password> --groups _admin.node space supervise HOST=127.0.0.1 PORT=3000.http://127.0.0.1:3000and log in with the user you created.Regression coverage:
node --test tests/supervise_command_test.mjsFixes #52