Skip to content

fix(widgets): require fresh source view before mutating an existing widget #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nsyring wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(widgets): require fresh source view before mutating an existing widget #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/L0/_all/mod/_core/onscreen_agent/prompts/system-prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,12 @@ traces
- readWidget just succeeded on the same widget
- _____user says do it, then do it, or execute
- assistant patches that widget now from the fresh source
- behavior change requires fresh source
- the user asks to change, fix, repair, validate, adjust, or improve an existing widget by name or id
- no readWidget, patchWidget, renderWidget, or reloadWidget on that widget id has succeeded earlier in this conversation, or the source for that id is no longer fully visible in the current prompt
- assistant calls readWidget on that widget id now
- assistant does not patch, render, or upsert that widget in this same turn
- assistant does not reconstruct the widget from memory or from rendered HTML
- create-one after empty catalog
- widget discovery already returned [empty]
- _____user says create one
Expand Down
8 changes: 8 additions & 0 deletions app/L0/_all/mod/_core/spaces/ext/skills/space-widgets/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,14 @@ patch vs rewrite
- If you build edits programmatically, parse the numbered renderer lines from readWidget() output or Current Widget `source↓`. Do not use widget.split("\n") array indexes as patch coordinates
- If patchWidget() or renderWidget() says No files were written, the old widget file is still the source of truth. Fix and retry

read before mutate
- Before any patchWidget(), renderWidget(), or upsertWidget() on an existing widget id, the assistant must have a fresh source for that id
- A source is fresh when it came from a readWidget(), patchWidget(), renderWidget(), or reloadWidget() success on that same id earlier in the live conversation
- If the source for that id is no longer fully visible in the current prompt, or only the start and end of it are visible, call readWidget(id) first and patch on the next turn
- Never reconstruct a widget from memory, from the rendered HTML returned by seeWidget(), or from a guess at the original source. seeWidget() is for visual verification only and is never authoritative for source
- Treat a user complaint about widget behavior as a patch trigger, not a rewrite trigger. Read first, then patch the specific lines that change
- renderWidget() on an existing widget id replaces the entire renderer. Use it only for new widget ids, for explicit user requests to start over from scratch, or when the framework explicitly requires a full rewrite

example exact snippet patch
_____javascript
return await space.current.patchWidget("snake-game", {
Expand Down