fix(volcengine): rethrow errors in catch blocks instead of returning them#177
Open
Ricardo-M-L wants to merge 1 commit into
Open
fix(volcengine): rethrow errors in catch blocks instead of returning them#177Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
…eturning them All five VolcengineProvider methods (createSandbox, deleteSandbox, getSandbox, setSandboxTimeout, listSandboxes) caught errors and then did `return error`, treating the caught Error as a success value. The caller's `await provider.createSandbox(...)` would resolve with an Error instance instead of rejecting, which means try/catch at the call site never triggers and consumers can't distinguish success from failure without explicit `instanceof Error` checks on every response. Changed all catch blocks to `throw error` so promise rejections propagate naturally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #176.
All five
VolcengineProvidermethods catch errors and silently return them as values, which means the caller's Promise resolves with anErrorinstance instead of rejecting. Standardtry { await provider.xxx() } catch (e) {}patterns never trigger, making failures invisible.Changed every
return errorin acatchblock tothrow errorso rejections propagate naturally.Affected methods
createSandbox(line 89)deleteSandbox(line 127)getSandbox(line 205)setSandboxTimeout(line 244)listSandboxes(line 304)Test plan
sdk/js/__test__/providers/volcengine.test.tswith 5 tests, one per method — each mocksrequestto reject, then asserts the provider method rejects with the same error.Related
Part of splitting closed PR #167 into focused single-bug PRs. Previously opened: #171 (Bug 1), #173 (Bug 2), #175 (Bug 3). This is Bug 4.
🤖 Generated with Claude Code