feat: respect flat skill layouts#24
Closed
philoserf wants to merge 1 commit intoagent-ecosystem:mainfrom
Closed
Conversation
Root-level support files alongside SKILL.md now receive equivalent treatment to files in references/, scripts/, and assets/ subdirectories. - Add classifyRootFile() to categorize root files as reference (.md), script, asset, or extraneous - Extract shared IsExtraneousFile() helper to util package - Count root .md files as reference tokens with per-file limits, deduplicate against references/ directory - Count root text assets in standard token table - Detect orphaned root support files in BFS reachability analysis - Check root .md files for unclosed code fences - Include non-extraneous root .md files in reference analysis - Add testdata/flat-skill/ fixture for integration testing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
I know that is a lot of change. I like flat skills until I need structure. I come from the one file until you need another. one folder until you need another, school. There were existing fumpt/lint as well. Since they were not in my change I left them. |
Contributor
Author
|
Closing. We can reconstruct if the conversation on the issue is resolved in favor of flexibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/,scripts/, andassets/subdirectoriesclassifyRootFile()to categorize root files as reference (.md), script, asset, or extraneousIsExtraneousFile()helper toutilpackage.mdfiles are deduplicated againstreferences/(subdirectory takes precedence)Closes #23
Test plan
testdata/flat-skill/fixturego vet,golangci-lint,gofumptall clean./skill-validator check testdata/flat-skill/shows only README.md warning🤖 Generated with Claude Code