Break out validation, judging, and structural checks into lib#21
Merged
Break out validation, judging, and structural checks into lib#21
Conversation
Member
Author
|
Closes #16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/to top-level so they're importable by external toolsvalidatorpackage toskillcheck(avoids collision with go-playground/validator)main.gotocmd/skill-validator/(standard Go project layout)No behavior changes. All existing tests pass.
See #16 for context and architectural decision rationale.
New install path
This is a breaking change for install path when using Go.
Becomes:
This has been a pre-release package, so I'll consider it a wash, but will bump the version to v1.0.0 and cut a release alongside some other new functionality/functionality changes.
Test plan
go build ./cmd/skill-validatorgo test -race ./... -count=1golangci-lint run ./...go doc ./judgeconfirms packages are publicly importablego install ./...produces correct binary name (pre-commit compat)