Add live-watch newMessages#89
Merged
Merged
Conversation
Contributor
Author
|
Self-review after implementation, taking the requested outsider/senior-dev stance:
Recommended action/fix: keep the response shape additive instead of changing Applied: no behavioral change needed beyond the worker implementation.
Recommended action/fix: add a short watchdog to the CLI test helper that kills the spawned process if it fails to exit. Applied: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newMessagesarray toagent-comms live-watchresponses.newMessageswith compact peer-only messages whosecreatedAtis after the watch start time, so agents can distinguish fresh arrivals from pre-existing actionable state.newMessageson both actionable and timeout responses, with nested conversation entries in timeoutlatest.Closes #83
Impact
This is additive to the existing
live-watchresponse. ExistinglatestActionableMessage, status handling, timeout shape, and polling behavior remain compatible.Validation
npm test -- --run tests/cli.test.tsnpm testnpm run checknpm run buildMilestone
No repo milestones are currently configured, so none was assigned.