You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Splitting the
core Yoneda lemma (yoneda, yonedaᴾ, yoneda*, yonedaᴾ*) from the
embedding/application material (yo, YO, isFullYO, isFaithfulYO, isFullyFaithfulYO) felt like a small cleanup in the spirit of #1267 (separating core
constructions from derived/application material).
I restored the split into two files so this PR focuses only on the renaming cleanup and keeps the diff easier to review.
dancewithheart
changed the title
Split Yoneda embedding into separate module and rename helper functions
Rename helper functions in Yoneda
Mar 16, 2026
Thanks sorry about the delay. Typically we split files like this into Base which have just the core construction with minimal imports, and then Properties etc that may pull in more imports. So the correct style for this repo if we were to split the files would be to put the core in Cubical.Categories.Yoneda.Base, the other stuff in Cubical.Categories.Yoneda.Properties and then have a module Cubical.Categories.Yoneda that re-exports everything from Base and Properties. This helps to avoid circular dependencies. In this case, since the imports weren't any different between the two modules it doesn't really make much of a difference so I don't think we should bother.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename helper functions in
Cubical.Categories.Yoneda:yo-yo-yo→yonedaToElementno-no-no→elementToYonedaPartially addresses #1285.