Hiding the action button that correspond to the current state#42
Open
lsgoulart wants to merge 1 commit intoafonsopacifer:masterfrom
Open
Hiding the action button that correspond to the current state#42lsgoulart wants to merge 1 commit intoafonsopacifer:masterfrom
lsgoulart wants to merge 1 commit intoafonsopacifer:masterfrom
Conversation
Collaborator
|
LGTM |
|
this makes sense as an interaction, most buttons are pause/play and only show the button that will transition state e.g. if currently playing it shows the pause button, if paused it shows the play button, see -> youtube |
Collaborator
|
Yeah, @audiolion! I'm looking now fondly the implementation and it doest not make sense as it will impair the usability. People are not accustomed to using this way, I think can confuse them. What do you think @afonsopacifer ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.