Faza 5: curățenie și documentare — migrarea e completă#44
Merged
Conversation
- README brought up to date with the final architecture: module tree, XState v5 machine (after-delays, invoked actors, applyFx), Stately Inspector/editor pointers, the user-pause-vs-system-pause and sound-supervisor pieces of the offline story, test counts and the updated unit/e2e test tables (63 unit + SimulatedClock, 37 e2e). - Delete _unused_svgs/ and tailwind.config.js (v4 + the Vite plugin use CSS-based config; verified utilities still emitted without it). - Clean .gitignore: the root `public` pattern (build output moved to dist/ long ago) was silently ignoring NEW files added under src/public/ — a real trap; also drop the stale src/css/output.css. - plan.md: final status — phases 1/2/3/4a/5 complete; 4b (audioInstance redesign + feedback tone channel) remains, gated on device validation. Typecheck clean, 63/63 unit, build OK (CSS verified), 37/37 e2e, smoke. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CI Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ce face
Ultima fază mecanică din
plan.md— zero schimbări de comportament (e2e 37/37 neatins).after-delays, actori invocați,applyFx), pointerii Stately Inspector/editor, piesele noi din povestea offline (pauza user vs sistem, supervizorul de sunete), numărătorile corecte de teste (63 unit + SimulatedClock, 37 e2e) și tabelele actualizate._unused_svgs/șitailwind.config.js(Tailwind v4 + plugin-ul Vite folosesc config din CSS — verificat că utilitarele se emit identic fără el)..gitignorecurățat — inclusiv o capcană reală: pattern-ulpublic(rămas de când build-ul ieșea acolo) ar fi ignorat silențios orice fișier NOU adăugat însrc/public/(un sunet nou, o imagine nouă). Scos, împreună cusrc/css/output.css(nu se mai generează).plan.md: status final — fazele 1/2/3/4a/5 complete și în master; rămâne doar 4b (redesignaudioInstance+ canalul de feedback cutone), separat, condiționat de validare pe device.Verificare
✅ typecheck • ✅ 63/63 unit • ✅ build (CSS verificat fără config) • ✅ 37/37 e2e neatinse • ✅ smoke pe
vite preview🤖 Generated with Claude Code