Skip to content

Fix EXPPotential time interpolation at/near snapshot times#599

Merged
adrn merged 3 commits into
mainfrom
exp-time-interp-fix
Jun 8, 2026
Merged

Fix EXPPotential time interpolation at/near snapshot times#599
adrn merged 3 commits into
mainfrom
exp-time-interp-fix

Conversation

@adrn

@adrn adrn commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Describe your changes

Evaluating a time-evolving EXPPotential exactly at a stored snapshot time could silently snap to a neighboring snapshot interval, or raise FieldWrapper::interpolator: time t out of bounds at the first/last snapshot. This showed up for me when testing on some EXP coefficient files I had generated for testing.

This fix adds a small tolerance check to the interpolator when picking the relevant knot interval to use.

Checklist

  • Did you add tests?
  • n/a Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@adrn adrn added this to the v1.12 milestone Jun 8, 2026
@adrn adrn merged commit 67e0e35 into main Jun 8, 2026
29 checks passed
@adrn adrn deleted the exp-time-interp-fix branch June 8, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant