potential: allocate persistent scratch space for gradients#591
Open
lgarrison wants to merge 1 commit into
Open
potential: allocate persistent scratch space for gradients#591lgarrison wants to merge 1 commit into
lgarrison wants to merge 1 commit into
Conversation
Avoid repeated malloc/free calls when calculating gradients with transformed components. Uses thread-local scratch space that is allocated on first use and cached for reuse later. Note that this space is never freed! If working with large orbit arrays, this may result in higher than expected memory usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid repeated malloc/free calls when calculating gradients with transformed components. Uses thread-local scratch space that is allocated on first use and cached for reuse later.
Note that this space is never freed! If working with large orbit arrays, this may result in higher than expected persistent memory usage.
This is an alternate fix to #588.
@segasai, would you mind profiling this branch to see if it resolves your original issue?
Describe your changes
Checklist
CHANGES.rst)