Remove documentation for old Twitter Ally driver#213
Open
ThisIsMissEm wants to merge 1 commit intoadonisjs:mainfrom
Open
Remove documentation for old Twitter Ally driver#213ThisIsMissEm wants to merge 1 commit intoadonisjs:mainfrom
ThisIsMissEm wants to merge 1 commit intoadonisjs:mainfrom
Conversation
ThisIsMissEm
commented
May 7, 2025
Comment on lines
-79
to
+78
| Also, you must register the same callback URL within the `config/ally.ts` file using the `callbackUrl` property. | ||
| Also, you must register the same callback URL within the `config/ally.ts` file using the `callbackUrl` property. In many cases, you will want the callback URL to come from an Enviroment variable, or constructed based on a "public url" for your service. |
Contributor
Author
There was a problem hiding this comment.
Whilst this isn't directly related, having language that says "hey, your Callback URL will be different between different environments" is something we should have.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To complement adonisjs/ally#161