This repository was archived by the owner on Oct 5, 2021. It is now read-only.
Open
Conversation
added required fields, to match the database table constraints which is made by the built-in seeder. this might help new comers save time figuring out
removed the hashing of a password because it's done behind the scenes
Author
|
@thetutlage just wanted to point out that the api docs give example where you has the password however after trying to login, i realized that there is hook inside User model which hashes the password , so I was double hashing and it didn't work. I'm not sure if I misunderstood the intention of the docs, or maybe they need to be fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sum: added required fields, to match the database table constraints which is made by the built-in migration.
this might help new comers save time figuring out
in detail:
when trying to follow the docs it's a bit not clear how to put all the pieces together to create the first user especially for people who aren't familiar with migration, seeding and factories.
I'd even suggest adding UsersSeeder file with the code ready to go.
since following the docs the users table is created by the built-in migration comes with requirement fthat email and password are not null, and email has to be unique, I added those fields to the factory as well, this will allow people to generate multiple users easily