Skip to content

Lgandola/popover on thumbnail#745

Merged
Lucag101 merged 5 commits intomainfrom
lgandola/popover-on-thumbnail
Mar 27, 2026
Merged

Lgandola/popover on thumbnail#745
Lucag101 merged 5 commits intomainfrom
lgandola/popover-on-thumbnail

Conversation

@Lucag101
Copy link
Copy Markdown
Collaborator

When thumbnail images exist on the axis, users naturally try to select the thumbnail rather than the bar itself to open a popover. My change adds click ability to the thumbnail on bar axis with the addition of the 'hasPopover' option. When used on axis, thumbnail click causes a popover dialogue to open on and highlight the corresponding bar.

Motivation and Context

This extends popover behavior to the thumbnail beneath/beside bar marks.

How Has This Been Tested?

Stories, tests, and documentation have been added and updated accordingly

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@Lucag101 Lucag101 merged commit a14ca30 into main Mar 27, 2026
6 checks passed
@Lucag101 Lucag101 deleted the lgandola/popover-on-thumbnail branch March 27, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants