GH-264 allowing the ProviderService to be built with custom (auth and headers) request interceptors#265
Open
francoisledroff wants to merge 5 commits intomainfrom
Open
GH-264 allowing the ProviderService to be built with custom (auth and headers) request interceptors#265francoisledroff wants to merge 5 commits intomainfrom
ProviderService to be built with custom (auth and headers) request interceptors#265francoisledroff wants to merge 5 commits intomainfrom
Conversation
…nd headers) request interceptors
francoisledroff
had a problem deploying
to
aio_stage_oauth
GitHub Actions
Failure
francoisledroff
had a problem deploying
to
prod_oauth_itest
GitHub Actions
Failure
francoisledroff
had a problem deploying
to
aio_stage_oauth
GitHub Actions
Failure
francoisledroff
temporarily deployed
to
prod_oauth_itest
GitHub Actions
Inactive
francoisledroff
temporarily deployed
to
aio_stage_oauth
GitHub Actions
Inactive
francoisledroff
had a problem deploying
to
prod_oauth_itest
GitHub Actions
Failure
pratyushbanerjee
approved these changes
Mar 27, 2026
Collaborator
pratyushbanerjee
left a comment
pratyushbanerjee
left a comment
There was a problem hiding this comment.
LGTM, minor comments
Comment on lines
64
to
66
| * @throws IllegalStateException if the Workspace authentication context is not valid. | ||
| * @throws IllegalArgumentException if the Workspace authentication context is not valid. | ||
| */ | ||
| public ImsService build() throws IllegalStateException { |
Collaborator
There was a problem hiding this comment.
Javadoc and body were updated to IllegalArgumentException, but the method signature still declares throws IllegalStateException
Collaborator
Author
There was a problem hiding this comment.
thanks I fixed the javadocs
Comment on lines
-73
to
-81
| } | ||
| if (StringUtils.isEmpty(apiKey)) { | ||
| throw new IllegalStateException("Your `Workspace` is missing an apiKey"); | ||
| } |
Collaborator
There was a problem hiding this comment.
Javadoc still claims to validate "any properties," but apiKey and authContext checks were removed
Collaborator
Author
There was a problem hiding this comment.
thanks ! I polished the javadocs
…ing to this PR refactoring
francoisledroff
temporarily deployed
to
prod_oauth_itest
GitHub Actions
Inactive
francoisledroff
temporarily deployed
to
aio_stage_oauth
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GH-264 allowing the
ProviderServiceto be built with custom (auth and headers) request interceptorsRelated Issue
events_mgmt: allow the use of custom Feign request interceptor #264