Skip to content

feat/Cext-5606- add authorization token to request header#61

Merged
pdohogne-magento merged 16 commits intomainfrom
cext-5606
Mar 9, 2026
Merged

feat/Cext-5606- add authorization token to request header#61
pdohogne-magento merged 16 commits intomainfrom
cext-5606

Conversation

@AjazSumaiya
Copy link
Copy Markdown
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AjazSumaiya AjazSumaiya requested a review from nofuss February 10, 2026 10:20
Copy link
Copy Markdown
Collaborator

@nofuss nofuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several questions about IMS context and different types of tokens. Want to make sure I understand how this is supposed to work.

@pdohogne-magento
Copy link
Copy Markdown
Collaborator

pdohogne-magento commented Feb 11, 2026

A note: As this is backwards-incompatible, we cannot merge this PR until we're ready to do the auth cutover since it will block non-BIC changes from getting merged and released.

Copy link
Copy Markdown
Collaborator

@nofuss nofuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good but I think there are mistakes in the README

nofuss
nofuss previously approved these changes Feb 25, 2026
Copy link
Copy Markdown
Collaborator

@nofuss nofuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@pdohogne-magento
Copy link
Copy Markdown
Collaborator

I am still concerned about token expiration, the library will just stop functioning once the token that's passed to init() expires and that's no good.

@nofuss
Copy link
Copy Markdown
Collaborator

nofuss commented Feb 26, 2026

I am still concerned about token expiration, the library will just stop functioning once the token that's passed to init() expires and that's no good.

That's actually a good point. In many cases runtime actions are short lived, but for bulk operations they could run for far longer than 5 minutes. Please bring it up on the #commerce-project-app-builder-persistence channel. (I'll try as well, but I have other irons on the fire)

@pdohogne-magento pdohogne-magento merged commit 0b4d8fe into main Mar 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants