feat/Cext-5606- add authorization token to request header#61
feat/Cext-5606- add authorization token to request header#61pdohogne-magento merged 16 commits intomainfrom
Conversation
nofuss
left a comment
There was a problem hiding this comment.
Several questions about IMS context and different types of tokens. Want to make sure I understand how this is supposed to work.
|
A note: As this is backwards-incompatible, we cannot merge this PR until we're ready to do the auth cutover since it will block non-BIC changes from getting merged and released. |
nofuss
left a comment
There was a problem hiding this comment.
mostly good but I think there are mistakes in the README
|
I am still concerned about token expiration, the library will just stop functioning once the token that's passed to |
That's actually a good point. In many cases runtime actions are short lived, but for bulk operations they could run for far longer than 5 minutes. Please bring it up on the #commerce-project-app-builder-persistence channel. (I'll try as well, but I have other irons on the fire) |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: