chore: upgrade @oclif/core to v4 and eslint to v9 with flat config#34
Open
chore: upgrade @oclif/core to v4 and eslint to v9 with flat config#34
Conversation
- Upgrade @oclif/core from ^1.3.4 to ^4 (closes #33) - Update args definition from array to object format (oclif v4 API) - Add ignoreStdin: true to state arg to prevent test hangs with fake timers - Upgrade @adobe/eslint-config-aio-lib-config to 5.0.0 (ESLint v9 flat config) - Replace .eslintrc with eslint.config.js for ESLint v9 flat config - Upgrade eslint from ^8 to ^9, add neostandard peer dep - Remove eslint plugins now bundled by neostandard - Update test/index.test.js: add mockConfig with runHook and mock @adobe/aio-lib-core-config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shazron
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
Summary
@oclif/corefrom v1 to v4, fixing #33ignoreStdin: trueto thestatearg — oclif v4 now tries to read missing args from stdin using asetTimeouttimeout; without this,jest.useFakeTimers()causes test hangs on the second parse call@adobe/eslint-config-aio-lib-configto 5.0.0, which moves to ESLint v9 flat config with neostandard.eslintrcwitheslint.config.js(ESLint v9 flat config format)eslint-plugin-jestto v28test/index.test.jsto provide amockConfigwithrunHook(required by oclif v4'sparse()) and mocks@adobe/aio-lib-core-configTest plan
npm testsucceeds end-to-end🤖 Generated with Claude Code