Open
Conversation
Member
|
@csaunier thank you for submitting this PR. Our contributor's license agreement system seems to have run a foul, so we will see if we can get it back up. From briefly glancing at the PR, it looks like parts of it have come from other projects, which may make it difficult for us to accommodate it. Could you possible add a list of other other projects where code for this PR came from? |
Author
|
@lmclister indeed, i use some parts of only one another projet, Repond.js (https://github.com/scottjehl/Respond). More specifically, i use 4 of his regexp (one that strip comment, one that split on @media, two to get minwidth and maxwidth), and his method that return the value of 1em in pixels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
In case of a personnal project, i had to use some shapes in mediaqueries but the polyfill throw an error and it appear it was not handled. It's also #10 issue.
So here it is :)
I've wrote a demo file : demos/mediaQueries-demo.html