Open
Conversation
Author
|
any comments about this fix ? it really meaningful to fix it asap, when you handle php warnings as exceptions... |
|
Are you planning to merge this ? I was trying to use the lib but this bug makes it impossible to use for my purpose. |
|
+1 for merging. there really was a bug, this oneliner fixes it. |
|
^ Fourthed, please merge. Thanks. |
|
Please merge 👍 |
|
lgtm 👍 |
|
+1 |
1 similar comment
|
👍 |
|
great 👍 |
|
Don't expect any help here... Switch to Adldap2! |
muchar
approved these changes
Jul 26, 2017
datatim
approved these changes
Jul 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last array index with X elements will be X-1