python3 compatibility and PEP8 conformity#24
Open
wehlutyk wants to merge 1 commit intoaditya-grover:masterfrom
Open
python3 compatibility and PEP8 conformity#24wehlutyk wants to merge 1 commit intoaditya-grover:masterfrom
wehlutyk wants to merge 1 commit intoaditya-grover:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
We just started using node2vec in one of our projects, and needed python 3 compatibility, which is what this PR brings. It's mixed with style changes to conform to PEP8 (which I could remove if you prefer). The Py3 changes are very minor (admittedly lost in the bigger PEP8 conformity changes), but might be useful.
Thanks for the great software.