Skip to content

Add a way to reset password#38

Merged
adguernier merged 4 commits into
mainfrom
26-add-a-way-to-reset-password
Oct 22, 2025
Merged

Add a way to reset password#38
adguernier merged 4 commits into
mainfrom
26-add-a-way-to-reset-password

Conversation

@erwanMarmelab
Copy link
Copy Markdown
Collaborator

Capture.video.du.2025-10-22.14-46-14.mp4

@erwanMarmelab erwanMarmelab linked an issue Oct 22, 2025 that may be closed by this pull request
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frequentito Ready Ready Preview Comment Oct 22, 2025 1:45pm

@erwanMarmelab erwanMarmelab requested a review from Copilot October 22, 2025 12:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds password reset functionality to the application, allowing users to request a password reset link via email. The implementation includes email domain validation, user existence verification, and a dedicated UI page for initiating the reset process.

Key changes:

  • New /reset-password page with form UI for requesting password reset links
  • Server action implementing email validation, domain checking, and user verification before sending reset emails
  • Integration of "Forgot password?" link on the login page

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
app/reset-password/page.tsx New client component providing the password reset request UI with form validation and state management
app/reset-password/actions.ts Server action handling password reset requests with email domain validation and user existence checks
app/login/page.tsx Added "Forgot password?" link directing to the reset password page
utils/supabase/middleware.ts Excluded /reset-password route from authentication requirement
.env.development Updated allowed email domain to marmelab.com

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread app/reset-password/actions.ts Outdated
Comment thread app/reset-password/actions.ts Outdated
Comment thread .env.development Outdated
@adguernier
Copy link
Copy Markdown
Owner

polish: it's a security issue to send a feedback if the user email does not exist. Prefer to send a generic feedback like the second you display

Comment thread app/reset-password/actions.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread app/reset-password/actions.ts Outdated
Comment thread app/reset-password/page.tsx Outdated
@adguernier adguernier merged commit 56e52ec into main Oct 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way to reset password

3 participants