Skip to content
This repository was archived by the owner on Mar 12, 2020. It is now read-only.

Refactor Key/Value logic into KvClient#74

Open
winpat wants to merge 26 commits intoadfinis:masterfrom
winpat:refactor_kv_logic
Open

Refactor Key/Value logic into KvClient#74
winpat wants to merge 26 commits intoadfinis:masterfrom
winpat:refactor_kv_logic

Conversation

@winpat
Copy link
Copy Markdown
Contributor

@winpat winpat commented Feb 8, 2019 •
edited
Loading

With the more recent Vault releases, a version 2 of the key/value backend has been introduced. This new version has a different URL scheme, which is not compatible with the old one. (This is due to the fact that secrets are versioned in v2.)

Since we don't want to encode the logic of different URL schemes in every command, we refactor this into a new KvClient abstraction. This not only simplifies the code of the commands but also makes the code better testable.

This MR will be the base to support multiple versions of the k/v backend in the future.

@winpat winpat force-pushed the refactor_kv_logic branch from 96587d1 to d7aedae Compare April 18, 2019 15:43
@winpat winpat force-pushed the refactor_kv_logic branch from fcf5ac5 to d7aedae Compare April 18, 2019 15:58
@winpat winpat requested a review from hairmare April 18, 2019 16:31
winpat added 19 commits April 18, 2019 18:35
@winpat
Add KvClient skeleton
e293140
@winpat
Initalize KvClient in main.go
c219246
@winpat
Migrate insert command to KvClient
1458202
@winpat
Implement Put() on KvClient
3ae2835
@winpat
Add Getter to retrieve vault.Client from KvClient
12c9a89
@winpat
Add unit test for KvClient.Put()
3db6199
@winpat
Implement Get() on KvClient
991ad19
@winpat
Unmount test backend in SetupTestEnvironment() to ensure clean state
8229a2c
@winpat
Migrate show command to KvClient
f70eabf
@winpat
Implement Delete() on KvClient
b9bce28
@winpat
Migrate move command to KvClient
d780aff
@winpat
Rename GetRawClient() to RawClient() to be more idiomatic
fa3665d
@winpat
Migrate delete command to KvClient
2c8cafd
@winpat
Migrate edit command to KvClient
733d8a7
@winpat
Migrate copy command to KvClient
98fdb21
@winpat
Rename variable
fb3583c
@winpat
Implement List() and Traverse() on KvClient
e9e15e8
@winpat
Migrate list command to KvClient
df355e1
@winpat
Fix test suite of delete command
33695ce
@winpat winpat force-pushed the refactor_kv_logic branch from d7aedae to 33695ce Compare April 18, 2019 16:35
@winpat
Copy link
Copy Markdown
Contributor Author

winpat commented Apr 18, 2019

Looks like the tests are a bit flaky. I will fix them first.

@winpat winpat removed the request for review from hairmare April 18, 2019 16:48
@czosel czosel requested a review from hairmare April 23, 2019 06:42
@winpat winpat removed the request for review from hairmare October 23, 2019 11:07
@hairmare
Copy link
Copy Markdown

hairmare commented Dec 12, 2019

@winpat This fail is still open, other than that the changes look sane.

--- FAIL: TestList/ListExistingSecretsRecursively (0.01s)
   list_test.go:88: Wrong exit code. errors: 
       Unkown error occured: [*errors.errorString] "Secret does not exist"

@hairmare hairmare self-requested a review December 12, 2019 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hairmare hairmare Awaiting requested review from hairmare

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@winpat @hairmare @czosel