This repository was archived by the owner on Mar 12, 2020. It is now read-only.
WIP: Add support version 2 of key/value engine#69
Open
winpat wants to merge 13 commits intoadfinis:masterfrom
Open
WIP: Add support version 2 of key/value engine#69winpat wants to merge 13 commits intoadfinis:masterfrom
winpat wants to merge 13 commits intoadfinis:masterfrom
Conversation
If a secret is stored in a kv version 2 backend then add "/data/" inbetween the backend name and the secret path.
KvClient will handle k/v version 1 and 2 transparently.
"kv" is more descriptive then "vc".
We're only interested in passing around map[string]interace{} instead of vault.Secret's.
If a secret does not exist, KvClient should return an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.