Add logger configuration and support for command-line arguments#127
Merged
Add logger configuration and support for command-line arguments#127
Conversation
3a0c7d3 to
9dd2836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces configurable logging to the ADF Python framework. It allows users to specify the logger's file name and log levels via both configuration files and command-line arguments, improving flexibility and observability. The default logger settings are now loaded from
config/launcher.yamlor can be overridden at launch.Logger configuration enhancements:
file_name,file_level,stream_level) toconfig/launcher.yamlfor centralized and customizable logging setup.ConfigKeyfor logger-related settings, enabling easy retrieval and management of logger configuration values.configure_loggerfunction to accept parameters for log file name and log levels, and to apply these settings to both file and stream handlers. [1] [2]Launcher and CLI improvements:
--logger-file-name,--logger-file-level, and--logger-stream-levelarguments, allowing users to override logger settings at runtime.configure_logger, ensuring logger setup reflects user preferences.Project versioning:
0.2.8inpyproject.tomlto reflect these enhancements.