Adding read-only mode where user cannot pick a date#69
Closed
JayHuang wants to merge 2 commits into
Closed
Conversation
Author
|
Calendar still toggles for this version on tab focus, update coming. Edit: Updated, see commit below. |
Collaborator
|
@JayHuang Hey mate! This looks like an interesting feature and I think I would like to merge it to master 👍 But I see there are some conflicts, do you mind taking a look at those ? I am willing to do pair programming if needed to fix these :) |
This was referenced Apr 9, 2016
Author
|
@novarac23 I don't use ngQuickDate anymore, but I have created a new fork and submitted the same PR at #119 with conflicts resolved (dist files). Worth noting that ngQuickDate is failing 8 tests, but this occurs regardless of the changes in my PR. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding read-only option:
read-only="true"This makes the directive not trigger the popup, preventing the user from selecting a date.
See bottom form, data updates according to the model using $watch, but user cannot manually edit End Date.
