use ng-click instead of ng-mousedown for touch devices#112
use ng-click instead of ng-mousedown for touch devices#112GraemeRFalkner wants to merge 3 commits into
Conversation
Add two new options, both of which default to False to prevent any change of behaviour for legacy users. isTouchDevice: set to true to manually specify touch events detectTouchDevices: Detect if code is running on a touch device, and use touch events if applicable.
|
@GraemeRFalkner How do I reproduce this not working? It seems to work on my iPhone without using either of the new options. |
|
What version of Angular are you using? We found that ngQuickDate worked fine with Angular 1.0 but not with Angular 1.3.4 |
|
I still can't reproduce it (on the demo page) with either Angular 1.3.4 or 1.4.7 (the latest) on my iPhone 6 with iOS 9. It's very possible that it's breaking on other mobile platforms (Android or older versions of iOS) or by using a different set of circumstances from the demo page. |
|
Ok Thanks, I will investigate further to try to figure out why it doesn't work for us. |
|
@GraemeRFalkner Any updates on this ? Free to help out if its needed! |
|
@GraemeRFalkner Hey mate! Need any help with that investigation ? I am willing to help out if needed :) |
3 participants
ngQuickDate does not work on mobile devices with the current version of Angular 1.x.
The reason is that Angular does not emit an ng-mousedown when the user taps on a calendar entry.
Two new options have been added, both default to false to prevent breaking changes on legacy installations.
isTouchDevice: Allows ngQuickDate to be manually configured to use ng-click instead of ng-mousedown
detectTouchDevices: Detects if touch is available and uses ng-click or ng-mousedown as appropriate.
Updated version number to 1.3.4