chore: Bump pybind11 to v3.0.1#5162
Merged
kodiakhq[bot] merged 5 commits intoacts-project:mainfrom Feb 25, 2026
Merged
Conversation
Contributor
andiwand
approved these changes
Feb 25, 2026
|
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 26, 2026
Bumps the *builtin* pybind11 version to v3.0.1, and switches all non-LCG builds over to use the install from the dependencies package. Still uses the builtin one in LCG as it's not available there. This is in preparation for using `pybind11::smart_holder` in acts-project#5156.
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
This pull request refactors the logging system across several algorithms to allow for more flexible and explicit logger injection, improving consistency and configurability. It replaces constructors that accepted a logging level with constructors that accept a `std::unique_ptr<const Acts::Logger>`, and updates logging macro usage to support explicit logger instances. Additionally, it fixes a threshold check in the default filter policy. Logger injection and constructor changes: * Updated algorithm constructors (`AlignmentAlgorithm`, `GreedyAmbiguityResolutionAlgorithm`, `ScoreBasedAmbiguityResolutionAlgorithm`, `DigitizationAlgorithm`, `MuonSpacePointDigitizer`, `FatrasSimulation`, `Geant4Simulation`, `Geant4MaterialRecording`) to accept a `std::unique_ptr<const Acts::Logger>` instead of a logging level, enabling explicit logger configuration and improved dependency injection. [[1]](diffhunk://#diff-4e92c2bf05d730d02b72ae0a434b161217e052d784233ea902d45acffbff84ecL121-R122) [[2]](diffhunk://#diff-bc02a4e4bffc09acdf37fcc231267ce5d981763261e93d9a74231e14b5d9afb7L55-R56) [[3]](diffhunk://#diff-65f1ab261cb94dd18a9595791a6b56a5d8458a5a4dd563f11abc6d961b6f731aL67-R68) [[4]](diffhunk://#diff-ffd5de2d805cc7873b3d25c15ce0694d3740b9002ab1dcc2afb9b62ce8dc274eL91-R92) [[5]](diffhunk://#diff-2a4fab6c969ff5bca07ceef82edfe5101832f31b328db7006291258e9b47c107L70-R71) [[6]](diffhunk://#diff-0ad26218b74874a567663541d635eb31f42cc8ad5f063227a2f96c83a35416f5L86-R87) [[7]](diffhunk://#diff-65ce5532af3eb9070dfbe6f485c7692f369aab568d2d47e0865bb39a72da0944L160-R159) [[8]](diffhunk://#diff-65ce5532af3eb9070dfbe6f485c7692f369aab568d2d47e0865bb39a72da0944L203-R201) * Updated algorithm implementation files to use the new logger-based constructors and to clone loggers as needed for internal components. [[1]](diffhunk://#diff-70b445898c534cda78d3986040d4abb0a88a2486f98971e058de20bdcb650f36L22-R25) [[2]](diffhunk://#diff-052303701717a6071ca1e81e884d22b4cfa954811bb9c25ff22b82d646eca23fL46-R49) [[3]](diffhunk://#diff-3dbc0ca274002ee8f208fa35395b4f3dba3fa153783bd9951e9ec14f6f80a17aL89-R92) [[4]](diffhunk://#diff-636d1960fa0086fe3d1f889e83d22e0eaa540350aac03c9f913083b5a73cfb4eL30-R33) [[5]](diffhunk://#diff-9ba6af08a8f7539ccb1e8883e69ec45c0f2bbf58bb1bc2005011eb48896a9fe4L53-R55) [[6]](diffhunk://#diff-f39d71850a26e7e09e830c972eb65986cffe3bf651ea8e1505f791eaa684fbf3L180-R195) Logging macro improvements: * Introduced the `ACTS_LOG_WITH_LOGGER` macro to allow logging with an explicit logger instance, and refactored existing logging statements in algorithm implementations to use this macro for improved clarity and flexibility. [[1]](diffhunk://#diff-a32273ac7da775bd1703552c5f6340ad17a6b647d7f551ea11588d7fde66f8b9L66-R83) [[2]](diffhunk://#diff-636d1960fa0086fe3d1f889e83d22e0eaa540350aac03c9f913083b5a73cfb4eL212-R221) [[3]](diffhunk://#diff-636d1960fa0086fe3d1f889e83d22e0eaa540350aac03c9f913083b5a73cfb4eL227-R254) [[4]](diffhunk://#diff-636d1960fa0086fe3d1f889e83d22e0eaa540350aac03c9f913083b5a73cfb4eL261-R269) [[5]](diffhunk://#diff-9ba6af08a8f7539ccb1e8883e69ec45c0f2bbf58bb1bc2005011eb48896a9fe4L85-R91) [[6]](diffhunk://#diff-f39d71850a26e7e09e830c972eb65986cffe3bf651ea8e1505f791eaa684fbf3L180-R195) Simulation configuration changes: * Updated `FatrasSimulation` and related simulation setup to use explicit logger injection and logger cloning for subcomponents, improving logging consistency in simulation workflows. [[1]](diffhunk://#diff-f39d71850a26e7e09e830c972eb65986cffe3bf651ea8e1505f791eaa684fbf3L113-R126) [[2]](diffhunk://#diff-f39d71850a26e7e09e830c972eb65986cffe3bf651ea8e1505f791eaa684fbf3L202-R209) Logging filter policy fix: * Corrected the threshold comparison in `DefaultFilterPolicy` to use `>=` instead of `>`, ensuring proper validation of logging levels. Blocked by: - #5162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the builtin pybind11 version to v3.0.1, and switches all non-LCG builds over to use the install from the dependencies package. Still uses the builtin one in LCG as it's not available there.
This is in preparation for using
pybind11::smart_holderin #5156.