feat: Access to whiteboard from Python#5158
Open
paulgessinger wants to merge 8 commits intoacts-project:mainfrom
Open
feat: Access to whiteboard from Python#5158paulgessinger wants to merge 8 commits intoacts-project:mainfrom
paulgessinger wants to merge 8 commits intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Core
paulgessinger
force-pushed
the
feat/python-whiteboard
branch
2 times, most recently
from
8f8d3cf to
c7780fd
Compare
Contributor
paulgessinger
force-pushed
the
feat/python-whiteboard
branch
from
c7780fd to
12c8631
Compare
Member
benjaminhuth
left a comment
benjaminhuth
left a comment
There was a problem hiding this comment.
Very cool! Some questions below:
| class WhiteBoardRegistry { | ||
| public: | ||
| using DowncastFunction = std::function<pybind11::object( | ||
| const void* data, const pybind11::object& wbPy)>; |
Member
There was a problem hiding this comment.
Hmm so we cannot use std::any here, that could contain T *?
Member
Author
There was a problem hiding this comment.
I can try. I'm not sure it'll work, given that we also have to use the type hash to do our type comparisons. std::any has to do those as well, let's see if they work.
|
|
||
| namespace ActsPython { | ||
|
|
||
| class WhiteBoardRegistry { |
Member
There was a problem hiding this comment.
I think for maintainability it would be great to summarize the purpose / concept / idea of this class.
Python/Utilities/include/ActsPython/Utilities/WhiteBoardTypeRegistry.hpp
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.