refactor!: Revise MultiStepper interface for BoundTrackParameter compatibility#5139
Draft
andiwand wants to merge 3 commits intoacts-project:mainfrom
Draft
Conversation
github-actions
bot
added
Component - Core
Contributor
…tistepper-singlestepper-compatibility
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the
MultiStepperinterface to return usualBoundTrackParameteronboundStateandcurvilinearState. This way theMultiStepperis directly compatible with a single stepper. The detailed, additional capabilities are exposed with the new methodsmultiBoundStateandmultiCurvilinearState.Additionally the
PropagatorResultis changed to return concreteBoundTrackParameterfor final parameters and additionallyMultiComponentBoundTrackParameterin case a multi stepper is in use and final parameters are requested. Effectively dropping the template parameter for the final track params.This is useful for the usage of the multi stepper for the electron track finding with the CKF. There we only depend on the aggregated bound state for measurement comparison for now. The aggregation logic is abstracted with the new interface.
--- END COMMIT MESSAGE ---
blocked by:
MultiComponentBoundTrackParameters::merge#5137