feat: Add seeds from three layer combinatorics in the combinatorial seed solver for New Small Wheel#5133
Merged
kodiakhq[bot] merged 8 commits intoacts-project:mainfrom Feb 25, 2026
Conversation
github-actions
bot
added
Component - Core
junggjo9
suggested changes
Feb 20, 2026
Contributor
junggjo9
reviewed
Feb 20, 2026
github-actions
bot
removed
Component - Examples
Co-authored-by: junggjo9 <junggjo90@gmail.com>
junggjo9
reviewed
Feb 22, 2026
Co-authored-by: junggjo9 <junggjo90@gmail.com>
junggjo9
previously approved these changes
Feb 23, 2026
andiwand
reviewed
Feb 25, 2026
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
acts-policybot
bot
dismissed
junggjo9’s stale review
Invalidated by push of f4aa497
andiwand
approved these changes
Feb 25, 2026
|
JustusRudolph
pushed a commit
to JustusRudolph/acts
that referenced
this pull request
Feb 26, 2026
…eed solver for New Small Wheel (acts-project#5133) This PR introduces the functionality of constructing a seed from three layers (instead of only four) where one 2D measurement and two strip measurements are available (e.g Combination of one sTgc and two MMs layers in the New Small Wheel of the ATLAS Muon Spectrometer) implemented with overloaded functions - Add the overloaded functions - Split the file in ipp for the definitions - Also additional tests with this feature are considered. - Add the dimension method in the muon space points for quick access to whether the measurement is 1D or 2D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the functionality of constructing a seed from three layers (instead of only four) where one 2D measurement and two strip measurements are available (e.g Combination of one sTgc and two MMs layers in the New Small Wheel of the ATLAS Muon Spectrometer) implemented with overloaded functions
--- END COMMIT MESSAGE ---
The mathematics are also documented here
https://gitlab.cern.ch/atlas-nextgen/work-package-2.5/analyticalsegment
@junggjo9 @patrick-scholer @noemina