Fix spec for attrs() to allow lists of tuples#4
Merged
ananthakumaran merged 1 commit intoactivesphere:masterfrom Mar 25, 2025
Merged
Fix spec for attrs() to allow lists of tuples#4ananthakumaran merged 1 commit intoactivesphere:masterfrom
ananthakumaran merged 1 commit intoactivesphere:masterfrom
Conversation
`[{:binary, :binary}]` only matches on the atom `:binary`, rather than
on the type `binary()`.
Contributor
Author
|
Thanks for merging! Do you have a sense of when you will release a new version? I'd like to start using lists of tuples in a library that depends on xml_stream. |
Contributor
|
Published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[{:binary, :binary}]only matches on the atom:binary, rather than on the typebinary().