Skip to content

Practice pull request; review me please#2

Open
WilcoFiers wants to merge 1 commit intodevelopfrom
link-name-rule
Open

Practice pull request; review me please#2
WilcoFiers wants to merge 1 commit intodevelopfrom
link-name-rule

Conversation

@WilcoFiers
Copy link
Copy Markdown
Member

This is a pull request for practicing reviews.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant