feat: Improve contact merge to use database query instead of loading potentially many many items#370
Open
driskell wants to merge 1 commit intoacquia:5.xfrom
Open
feat: Improve contact merge to use database query instead of loading potentially many many items#370driskell wants to merge 1 commit intoacquia:5.xfrom
driskell wants to merge 1 commit intoacquia:5.xfrom
Conversation
…potentially many many items
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently the contact item merge loads a huge amount of objects in some cases to migrate them to the new parent. It's better and faster to process as a query, similar to how all other merge operations are handled. It can process large amounts of items extremely quickly.
Steps to test this PR: