Fix campaign action to link contact with custom item UI issue

[npracht]

Q	A
Bug fix? (use the a.b branch)	✅
New feature/enhancement? (use the a.x branch)
Deprecations?
BC breaks? (use the c.x branch)
Automated tests included?
Related user documentation PR URL	not relevant
Related developer documentation PR URL	not relevant
Issue(s) addressed

Description:

In campaign when you try to link to a custom item, when you type in the input it should suggest the list of custom item existing (cf:acquia/mc-cs-plugin-custom-objects/wiki/Campaign-Events).

But the list is not displayed. I tried to write the custom item name, but doesn't work on contacts, the link is not done when campaign triggers.

Steps to test this PR:

1. Open this PR for testing locally (see docs on testing PRs here)
2. Be sure to have custom objects and items existing
3. Create a campaign and try to select an existing item, le list is not showing

[ShareBtech]

I have tried this fix and it is not working for me. Tested on 4.4.4 and 4.4.0

[lopesandre]

I've tested in 4.4.5 and this fix it does not work for me.

The only way that I can make it work is to set the hidden input value with the ID of the custom object manually (using the browser inspector).

For example, if you want to link the ID 2, just do:

document.getElementById("campaignevent_properties_linkCustomItemId").value = "2";

Then confirm that the ID is set:

document.getElementById('campaignevent_properties_linkCustomItemId').value

Then, just save it and it will work.

[jessebrightman]

Hello,

There is an error in the fix. The line is missing an opening parenthesis "(" The corrected code at line 13 should read:

if ((settings.type === 'POST' || settings.type === 'GET') && settings.url.indexOf('s/campaigns/events') >= 0) {

I have tested it and it works on v4.4.9

[RCheesley]

@npracht can you take a look at the feedback above?

[acquia-stalebot-platauto]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jos0405]

Hello,

There is an error in the fix. The line is missing an opening parenthesis "(" The corrected code at line 13 should read:

if ((settings.type === 'POST' || settings.type === 'GET') && settings.url.indexOf('s/campaigns/events') >= 0) {

I have tested it and it works on v4.4.9

The original PR is not working, but the suggestion above is working for me on 5.2.2.
Can someone modify tohe PR and we could merge it, it's pretty important fix.

[acquia-stalebot-platauto]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

[acquia-stalebot-platauto]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

[acquia-stalebot-platauto]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

[acquia-stalebot-platauto]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

[acquia-stalebot-platauto]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot