Template compilation caching to improve performance#73
Open
Nabihamasroor wants to merge 2 commits intoaccordproject:mainfrom
Open
Template compilation caching to improve performance#73Nabihamasroor wants to merge 2 commits intoaccordproject:mainfrom
Nabihamasroor wants to merge 2 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: nabiha <nmasroor@forthlogic.com>
…rocessor Signed-off-by: nabiha <nmasroor@forthlogic.com>
dselman
requested changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
I like this but:
- Is the validator a separate concern to the compilation output caching? It looks like it should be its own PR?
- I want to reimplement the compiler using the code I have in a draft PR removing the two slash dependency. Let me complete that work first then you can add caching on top.
Author
|
@dselman Thanks for the feedback! I'll wait for your refactor to be completed first. Let me know when I should rebase this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
Changes
TemplateValidatorclass for validating templates before processing-Implemented cache management with invalidateCache() and clearAllCaches() methods
Features